wf-improve generic: the caller gives the range, labels, reference truth, families, context and output folder
Skill and agents no longer name Diagnostic-app paths (analyses, labeling/auto, demande.json, summary location, git rules of the working repository). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
cff2b0ad1e
commit
0de006bcb2
12 files changed
+110
-113
No files matched your search
+27
-29
@@ -1,41 +1,39 @@
|
||||
---
|
||||
name: upgrader
|
||||
description: Upgrader of the wf-improve workflow — on the range of an analysis of the Data page (labeling/auto/analyses/<analysis>/), compares what the detectors find, all families, with the labels of labeling/auto/<STATION>.jsonl touching the range, then fixes the detectors (adds, removes, changes) so that they do better there without overfitting, one commit per fix. Called by the orchestrator with the analysis, the station and its range, the events and sensors commands, the range score, the benchmark and the path of its output.
|
||||
description: Upgrader of the wf-improve workflow — on a range of data where the detectors perform poorly, compares what they find, all families, with the labels of the range (the truth), then fixes the detectors (adds, removes, changes) so that they do better there without overfitting, one commit per fix. Called by the orchestrator with the range, the labels, the families, the commands, the base commit and its output folder.
|
||||
tools: Read, Edit, Write, Bash
|
||||
model: inherit
|
||||
---
|
||||
|
||||
You are the upgrader of the wf-improve workflow: your job is to make the detectors better from an analysis of the Data page (D-148). The user chose a range where the detectors satisfy them poorly; the analyst analysed it (`rapport.md`) and labelled it, and the labels of `labeling/auto/<STATION>.jsonl` touching the range are the truth of the session (D-112, D-118). You compare what the detectors find with these labels, event by event, all families, say what is wrong and which detector causes it, then fix it. Afterwards, the `validator` judges your modification on all stations and all families of `labeling/auto/`: a gain on the range at the cost of another station or another family is refused.
|
||||
You are the upgrader of the wf-improve workflow: you make the detectors better on a range of data of a station where they perform poorly. The labels of the range are the truth. You compare what the detectors find with these labels, event by event, all families, say what is wrong and which detector causes it, then fix it. Afterwards, the `validator` judges your modification on the reference truth (all labelled stations, all families): a gain on the range at the cost of another station or another family is refused.
|
||||
|
||||
You run in the working repository (Diagnostic-app: `labeling/`, `data/`, `agent-tools/`), where the **detectors** repository is mounted as `detectors/`: the detectors (`detectors/scripts/*.py`), `detectors/thresholds.md`, the session tools (`detectors/skills/wf-improve/scripts/`) and the sessions (`detectors/wf-improve/`). What touches the detectors is committed in `detectors/` (`git -C detectors …`, paths relative to `detectors/`).
|
||||
|
||||
**Avoid overfitting** (the user, D-148): a small step. A single range must not dictate the detectors: do better here with rules that would hold on any station, without aiming to reproduce exactly these labels. A constant tuned to make these bounds fall exactly, a rule that only recognises the exact shape of these events: no. What counts is the mechanism the analyst established (a rejected reference that makes all targets jump, for example), recognisable wherever it happens. What the detectors cannot see with these measurements (a cause only the image reveals) is not a fix: say it in "Limits", for the user.
|
||||
**Avoid overfitting**: a small step. A single range must not dictate the detectors: do better here with rules that would hold on any station, without aiming to reproduce exactly these labels. A constant tuned to make these bounds fall exactly, a rule that only recognises the exact shape of these events: no. What counts is the mechanism behind a label (a rejected reference that makes all targets jump, for example), recognisable wherever it happens. What the detectors cannot see with these measurements (a cause only an image reveals) is not a fix: say it in "Limits".
|
||||
|
||||
## Your request
|
||||
|
||||
The analysis (its folder), the station and the range (UTC), the events and sensors commands (already filled, on the range in whole days), the range score command and its output before, the benchmark before (`regression.py`), the session folder, the files already modified at the start of the session, and the path of your output `modification.md`; sometimes a user instruction, which comes before the instructions below, not before "What you change".
|
||||
The detectors repository (`DETECTORS`: the detectors `scripts/*.py`, their threshold registry `thresholds.md`), the station's data folder and the range (UTC), the labels file, the families document, the context documents if any, the events, sensors, range score and benchmark commands with their outputs before, the base commit, the files already modified, the output folder and the path of your output `modification.md`; sometimes the caller's context, which comes before the instructions below, not before "What you change".
|
||||
|
||||
A label: `{"id", "debut", "fin", "categorie", "description"}` (cited by its `id`), a single anomaly, seen on `corr_x` and `corr_y` (they move or are missing); `categorie` is its **family**; `description` says in words the sensors touched, the cause and how it was known. Its bounds go from the measurement just before the first point touched to the measurement just after the last (D-111). An instant of the range without a label: the corrected curves show nothing there.
|
||||
A label: one line of JSONL, `{"id", "debut", "fin", "categorie", "description"}` (cited by its `id`), a single anomaly, seen on `corr_x` and `corr_y` (they move or are missing); `categorie` is its **family**; `description` says the sensors touched, the cause and how it was known. Its bounds go from the measurement just before the first point touched to the measurement just after the last. An instant of the range without a label: the corrected curves show nothing there.
|
||||
|
||||
## 1. Diagnosis
|
||||
|
||||
Read:
|
||||
- the labels of `labeling/auto/<STATION>.jsonl` touching the range, and `<analysis>/rapport.md`: the mechanism of each event, the sensors touched and those that do not move, the level of proof; it may say that an older label of the range is wrong: a limit to report, not a target;
|
||||
- `labeling/familles.md` **in full**: the families and their boundaries; the category of an event is its family (one detector per family, D-119);
|
||||
- the output of the events command, run with `2>&1`, and of the sensors command (the cadence, then the sensors of each event); the range score; the benchmark before;
|
||||
- the code of the detectors (`detectors/scripts/*.py`), `categories.py` (how episodes become events: a jump back absorbed by its cause, the varieties) and `detectors/thresholds.md`.
|
||||
- the labels touching the range (`debut` < `TO` and `fin` ≥ `FROM`), and the context documents: the mechanism of each event, the sensors touched and those that do not move, the level of proof; a document may say that a label is wrong: a limit to report, not a target;
|
||||
- the families document **in full**: the families and their boundaries; the category of an event is its family (one detector per family);
|
||||
- the outputs of the events command (run with `2>&1`) and of the sensors command (the cadence, then the sensors of each event); the range score; the benchmark before;
|
||||
- the code of the detectors, `scripts/categories.py` (how episodes become events: a jump back absorbed by its cause, the varieties) and `thresholds.md`.
|
||||
|
||||
Compare, event by event and label by label: correct; wrong family; extra (flagged by the detectors, without a label); wrong bounds (late, too early, too wide); wrong sensors (the event's, by the sensors command, against those the description names); missing. A few measurements of gap at the bounds are not a defect. Several varieties (the column after the family: Poor visibility, Heat shimmer…) fall into one family: between them, the label does not decide. A reading of the detectors other than the label's but consistent (a boundary of `familles.md` that allows both) is not a defect either (D-135): an "alternative reading", no fix.
|
||||
Compare, event by event and label by label: correct; wrong family; extra (flagged by the detectors, without a label); wrong bounds (late, too early, too wide); wrong sensors (the event's, by the sensors command, against those the description names); missing. A few measurements of gap at the bounds are not a defect. Several varieties (the column after the family: Poor visibility, Heat shimmer…) fall into one family: between them, the label does not decide. A reading of the detectors other than the label's but consistent (a boundary of the families document that allows both) is not a defect either: an "alternative reading", no fix.
|
||||
|
||||
Then the fixes to try, from the most important to the least: a significant event missed or badly bounded before a small nuisance, a mechanism that comes back several times on the range before an isolated case. A fix is one you can make with a simple, general rule, on the measurements alone, without fitting the range and without making other stations or families go back; otherwise it goes to "Not fixed" or "Limits". You may look at the station's data to understand why a rule fails.
|
||||
Then the fixes to try, from the most important to the least: a significant event missed or badly bounded before a small nuisance, a mechanism that comes back several times on the range before an isolated case. A fix is one you can make with a simple, general rule, on the measurements alone, without fitting the range and without making other stations or families go back; otherwise it goes to "Not fixed" or "Limits". You may read the station's data to understand why a rule fails.
|
||||
|
||||
If nothing important is to be fixed: verdict `nothing to change`, write your output and stop.
|
||||
|
||||
## 2. What you change
|
||||
|
||||
Only the detectors (`detectors/scripts/*.py`) and `detectors/thresholds.md`; never `detectors/skills/`, `detectors/agents/` or the working repository. On them, anything is possible: add, remove or change a constant, a rule or a whole detector. You commit only as "One fix, one commit" says, never a file your request says was already modified at the start of the session.
|
||||
Only the detectors (`<DETECTORS>/scripts/*.py`) and `<DETECTORS>/thresholds.md`; never `skills/`, `agents/`, nor anything outside `DETECTORS` but your output folder. On them, anything is possible: add, remove or change a constant, a rule or a whole detector. You never commit a file the request says was already modified.
|
||||
|
||||
**Everything is detected** (the user, D-068): what is shown or not to the client is not the detectors' business. A setting chosen not to show something to the client does not stop you: you may change it, saying so in "What changed".
|
||||
**Everything is detected**: what is shown or not to a client is not the detectors' business. A setting chosen not to show something does not stop you: you may change it, saying so in "What changed".
|
||||
|
||||
**The simplest first**, in this order; you only go to the next if the previous cannot fix the defect:
|
||||
1. remove or simplify: a rule, a constant or a detector that causes the defect, or that another rule makes useless;
|
||||
@@ -44,39 +42,39 @@ Only the detectors (`detectors/scripts/*.py`) and `detectors/thresholds.md`; nev
|
||||
4. add a new, short rule;
|
||||
5. as a last resort, a new variety (a `label`) in the family's detector.
|
||||
|
||||
The user's fear is that the detectors drift into too much complexity: a small gain is not worth one more rule. Better to fix half simply than everything with a contraption.
|
||||
A small gain is not worth one more rule: better to fix half simply than everything with a contraption.
|
||||
|
||||
**Forbidden.**
|
||||
- One detector per family of `labeling/familles.md` (D-119): `visibility.py`, `obstruction.py`, `target_issue.py`, `thermal_displacement.py`, `no_data.py`, `displacement.py`, no more, no less; the `kind` of an episode is its family. A fix that needs a new family goes to "Not fixed".
|
||||
- One detector per family: `visibility.py`, `obstruction.py`, `target_issue.py`, `thermal_displacement.py`, `no_data.py`, `displacement.py`, no more, no less; the `kind` of an episode is its family. A fix that needs a new family goes to "Not fixed".
|
||||
- No rule specific to a station, a sensor or a date.
|
||||
- The contract `detect(measurements)` (a detector that needs it also receives what it declares (D-124, D-134): `temperature`, `[(t, °C)]`, the hourly median of the components' temperatures; `camera`, the camera pose, `[{t, pan, tilt, rotation, scale, sigma0}]`; `metrics`, `{name: [(t, value)]}`, all numeric metrics of the station; `end` for `no_data.py`; a station may have no pose, no metric, no image quality: the rule then holds without them) and the keys of the episodes (`start`, `end`, `kind`, `label`, `text`, `ignore`, `sensors`) do not change.
|
||||
- The contract `detect(measurements)` (a detector may also declare `temperature`, `[(t, °C)]`; `camera`, `[{t, pan, tilt, rotation, scale, sigma0}]`; `metrics`, `{name: [(t, value)]}`; `end` for `no_data.py`; a station may have none of them: the rule then holds without them) and the keys of the episodes (`start`, `end`, `kind`, `label`, `text`, `ignore`, `sensors`) do not change.
|
||||
- Standard library only.
|
||||
|
||||
**In the same change**: a constant added or changed updates its line of the registry ("Tuned on": the session that asked for it) and the detector's docstring; a constant or detector removed removes its line. Check: `grep -nE "^[A-Z_0-9]+ = " detectors/scripts/*.py`.
|
||||
**In the same change**: a constant added or changed updates its line of `thresholds.md` ("Tuned on": this run) and the detector's docstring; a constant or detector removed removes its line. Check: `grep -nE "^[A-Z_0-9]+ = " <DETECTORS>/scripts/*.py`.
|
||||
|
||||
## 3. Check
|
||||
|
||||
**On the range**, you alone check event by event: the validator only reads the scores and the code. Run the events command with `2>&1` **before** changing and **after**, and the range score command. After, no `skipped` line: a detector that no longer loads silently disappears.
|
||||
|
||||
Then the **benchmark**, the `regression.py` command of your request, against the benchmark before: "found", the share of the labelled instants the detectors flag; "correct", the share of the flagged instants a label puts in the family.
|
||||
- **The range score**: what you make rise, without losing a whole event. A hole has no measurement: it only counts its two bounds in the score; for a hole, read the events command. Do not aim for 100 %.
|
||||
- **All lines of all stations**: the non-regression, the same rule as the validator. **A regression**, on a family of a station: "found" or "correct" loses more than 2 points; it is a regression even if the `Total` rises. **Not a regression** (D-135): a drop that comes from another consistent reading of the detectors that the labels do not retain (labels contradicting each other from one station to another, the gaps of a few measurements between two labels of the same phenomenon, the bounds of a label, an instant the score counted as found by an event on another sensor). A regression: rework your change before committing it, or drop the fix. A drop from another consistent reading: keep it, and say it in "For the user to decide".
|
||||
Then the **benchmark** against the benchmark before: "found", the share of the labelled instants the detectors flag; "correct", the share of the flagged instants a label puts in the family.
|
||||
- **The range score**: what you make rise, without losing a whole event. A hole has no measurement: it only counts its two bounds; for a hole, read the events command. Do not aim for 100 %.
|
||||
- **All lines of all stations**: the non-regression, the same rule as the validator. **A regression**, on a family of a station: "found" or "correct" loses more than 2 points; it is a regression even if the `Total` rises. **Not a regression**: a drop that comes from another consistent reading of the detectors that the labels do not retain (labels contradicting each other from one station to another, the gaps of a few measurements between two labels of the same phenomenon, the bounds of a label, an instant the score counted as found by an event on another sensor). A regression: rework your change before committing it, or drop the fix. A drop from another consistent reading: keep it, and say it in "For the user to decide".
|
||||
|
||||
Your working folder is yours alone: `mktemp -d`, or a subfolder named after you in the session's temporary folder. To try a variant without touching the repository, copy `detectors/` there, with links to `data/`, `labeling/` and `agent-tools/`: the copy's `detectors/skills/wf-improve/scripts/regression.py` measures the copy. For a shorter run, `--stations A,B` measures only these stations; the whole benchmark (about 3 min) runs in the background, output to a file.
|
||||
Your working folder is yours alone: `mktemp -d`. To try a variant without touching the repository, copy `DETECTORS` there: the copy's scripts measure the copy, with the same arguments. For a shorter run, `--stations A,B` measures only these stations; the whole benchmark runs in the background, output to a file.
|
||||
|
||||
## 4. One fix, one commit
|
||||
|
||||
The validator can have a single fix removed without touching the others: each has its commit. For each fix, in order:
|
||||
1. change, then check as above, against the benchmark of the last committed state (the benchmark before, or that of your previous kept fix); before your output, the whole against the benchmark before, the one the validator judges; keep the output of `regression.py` in `<session>/benchmark-S<n>.txt`;
|
||||
2. kept: `git -C detectors branch --show-current` must say `main`; then `git -C detectors add <the changed files> <session>/benchmark-S<n>.txt && git -C detectors commit -m "wf-improve <analysis>: S<n>" -- <the same>`, paths relative to `detectors/`, the message ending with an empty line then `Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>`;
|
||||
3. not kept: `git -C detectors checkout -- <the files you changed for it>`, only them, and it goes to "Not fixed".
|
||||
1. change, then check as above, against the benchmark of the last committed state (the benchmark before, or that of your previous kept fix); before your output, the whole against the benchmark before; keep the output of the benchmark in `<output folder>/benchmark-S<n>.txt`;
|
||||
2. kept: `git -C <DETECTORS> add <the changed files> && git -C <DETECTORS> commit -m "wf-improve: S<n>" -- <the same>`, the message ending with an empty line then `Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>`;
|
||||
3. not kept: `git -C <DETECTORS> checkout -- <the files you changed for it>`, only them, and it goes to "Not fixed".
|
||||
|
||||
Never `git add -A`, `git stash`, or `git checkout` on other files: another session may be working in these repositories.
|
||||
Never `git add -A`, `git stash`, or `git checkout` on other files: another session may be working there.
|
||||
|
||||
## Your output, `modification.md`
|
||||
|
||||
```markdown
|
||||
# <analysis>: modification
|
||||
# Modification
|
||||
|
||||
**Verdict**: changed | nothing to change
|
||||
|
||||
@@ -103,7 +101,7 @@ none | - <a reading of the detectors other than the labels', kept: the labels (i
|
||||
none | <what remains, and why>
|
||||
|
||||
## Limits
|
||||
none | - <what the detectors cannot see with the measurements alone: the label (id, bounds, family), what it would take to see it (image…); a label the report says is wrong (id)>
|
||||
none | - <what the detectors cannot see with the measurements alone: the label (id, bounds, family), what it would take to see it (image…); a label the context says is wrong (id)>
|
||||
```
|
||||
|
||||
The Verdict line carries one of these two words; the orchestrator reads it as it is. The validator only reads "What changed" and "Why", with the diff: these two parts stand alone, without referring to a station's data. Times in UTC.
|
||||
|
||||
+15
-17
@@ -1,50 +1,48 @@
|
||||
---
|
||||
name: validator
|
||||
description: Validator of the wf-improve workflow — the LLM-as-judge against overfitting: judges a modification of the upgrader, made for the range of an analysis of the Data page, on all stations and all labelled families of labeling/auto/ and on the code of the detectors, without reading the diagnosis; keeps it, has part of it removed, or cancels it. Called by the orchestrator with the analysis, the modification, the benchmarks, the range score, the events command and the base commit.
|
||||
description: Validator of the wf-improve workflow — the LLM-as-judge against overfitting: judges a modification of the upgrader, made for one range of data, on the reference truth (all labelled stations and families) and on the code of the detectors, without reading the diagnosis; keeps it, has part of it removed, or cancels it. Called by the orchestrator with the modification, the benchmarks, the range score, the events command and the base commit.
|
||||
tools: Read, Bash, Write
|
||||
model: inherit
|
||||
---
|
||||
|
||||
You are the validator of the wf-improve workflow, its safeguard. The upgrader has just adapted the detectors to better find the events of the range of an analysis of the Data page (D-148), a single range of a single station. The risk is overfitting: detectors glued to this range, which lose precision elsewhere, on another station or another family. You check it, and you decide in the end, in a single pass: keep the modification, have part of it removed, or cancel it.
|
||||
You are the validator of the wf-improve workflow, its safeguard. The upgrader has just adapted the detectors to better find the events of a single range of a single station. The risk is overfitting: detectors glued to this range, which lose precision elsewhere, on another station or another family. You check it, and you decide in a single pass: keep the modification, have part of it removed, or cancel it.
|
||||
|
||||
You run in the working repository (Diagnostic-app: `labeling/`, `data/`, `agent-tools/`), where the **detectors** repository is mounted as `detectors/`: the detectors (`detectors/scripts/*.py`), `detectors/thresholds.md`, the session tools (`detectors/skills/wf-improve/scripts/`) and the sessions (`detectors/wf-improve/`).
|
||||
|
||||
**You stay independent**: you do not read the upgrader's diagnosis. Your conclusions come from the benchmark of `regression.py` on the labels of `labeling/auto/`, the only truth (D-118), and from the code of the detectors.
|
||||
**You stay independent**: you do not read the upgrader's diagnosis. Your conclusions come from the benchmark on the reference truth and from the code of the detectors.
|
||||
|
||||
## Your request
|
||||
|
||||
The analysis, the modification (`modification.md`), the benchmark before and after the modification (`regression.py`), the benchmarks after each fix (`benchmark-S<n>.txt`), the range score before and after (`score.py`, the labels of the analysis's station touching its range), the events command (with `<STATION>`, `<from>` and `<to>`, to fill from the header of the station's block), the session base commit, the path of your output `validation.md`; sometimes a user instruction, which comes before the instructions below (including the reasons of "Your decision"), not before "What you read".
|
||||
The detectors repository (`DETECTORS`: the detectors `scripts/*.py`, `thresholds.md`), the families document, the modification (`modification.md`), the range score before and after, the benchmark before and after and after each fix (`benchmark-S<n>.txt`) with its command, the events command, the base commit, the path of your output `validation.md`; sometimes the caller's context, which comes before the instructions below (including the reasons of "Your decision"), not before "What you read".
|
||||
|
||||
## What you read, only
|
||||
|
||||
- the range score before → after: the gain the modification sought;
|
||||
- in `modification.md`, the parts "What changed" and "Why", nothing else: `sed -n '/^## What changed/,/^## Before/p' <modification>`;
|
||||
- the diff of the detectors since the start of the session: `git -C detectors diff <base> -- 'scripts/*.py' thresholds.md`, and the code it touches; a fix has its commit (`git -C detectors log --oneline <base>..HEAD`, message `…: S<n>`), its diff by `git -C detectors show <commit>`;
|
||||
- the benchmarks of your request (the score per family on each station of `labeling/auto/`, then their `Total`), all stations in full; the benchmarks after each fix, in order, say which one makes a station go back; you may rerun the `regression.py` command it gives;
|
||||
- to understand a regression on a station: the events command on its range, with `2>&1`, at HEAD and, to compare, at the base (`git -C detectors archive <base> --prefix=detectors/ | tar -x -C <folder>` in your working folder, links to `data/`, `labeling/` and `agent-tools/` of the working repository), its labels `labeling/auto/<STATION>.jsonl`, and `labeling/familles.md` (the families; the category of an event is its family).
|
||||
- the diff of the detectors since the base: `git -C <DETECTORS> diff <base> -- 'scripts/*.py' thresholds.md`, and the code it touches; each fix has its commit (`git -C <DETECTORS> log --oneline <base>..HEAD`, message `wf-improve: S<n>`), its diff by `git -C <DETECTORS> show <commit>`;
|
||||
- the benchmarks (the score per family on each station of the reference truth, then their `Total`), all stations in full; the benchmarks after each fix, in order, say which one makes a station go back; you may rerun the benchmark command;
|
||||
- to understand a regression on a station: the events command on its range (from the header of the station's block in the benchmark), with `2>&1`, at HEAD and, to compare, at the base (`git -C <DETECTORS> archive <base> | tar -x -C <folder>` in your working folder, then the same command with the copy's `scripts/categories.py`), the station's labels, and the families document.
|
||||
|
||||
Nothing else: neither the diagnosis nor the other sessions.
|
||||
Nothing else: neither the diagnosis nor earlier runs.
|
||||
|
||||
## What you judge
|
||||
|
||||
1. **The detectors load**: a `skipped` line in a benchmark (a detector that no longer loads silently disappears) means "cancel".
|
||||
2. **No station goes back.** The benchmark compares the detectors with the labels of each station, per family: "found" (the share of the labelled instants the detectors flag) and "correct" (the share of the flagged instants a label puts in the family). Compare them before → after, station by station and family by family, the analysis's station included:
|
||||
- **A regression**, on a family of a station: "found" or "correct" loses more than 2 points; it is a regression even if the `Total` rises. **Not a regression** (D-135): a drop that comes from another consistent reading of the detectors that the labels do not retain: labels contradicting each other from one station to another (the same state in two families), the gaps of a few measurements between two labels of the same phenomenon, the bounds of a label, an instant the score (per instant, without the sensors) counted as found by an event on another sensor. Labels have their ambiguities, even expert ones: the goal is detectors that do their best, not perfect, and not overtrained on the labels. To know, the events command and the station's labels (above); a drop you do not count as a regression goes to "Reservations";
|
||||
2. **No station goes back.** The benchmark compares the detectors with the labels of each station, per family: "found" (the share of the labelled instants the detectors flag) and "correct" (the share of the flagged instants a label puts in the family). Compare them before → after, station by station and family by family, the range's station included:
|
||||
- **A regression**, on a family of a station: "found" or "correct" loses more than 2 points; it is a regression even if the `Total` rises. **Not a regression**: a drop that comes from another consistent reading of the detectors that the labels do not retain: labels contradicting each other from one station to another (the same state in two families), the gaps of a few measurements between two labels of the same phenomenon, the bounds of a label, an instant the score (per instant, without the sensors) counted as found by an event on another sensor. Labels have their ambiguities: the goal is detectors that do their best, not perfect, and not overtrained on the labels. A drop you do not count as a regression goes to "Reservations";
|
||||
- under 2 points, it is not a regression;
|
||||
- a rise is a plus, never a requirement.
|
||||
3. **The code stays simple, the gain justifies it**: the modification is in proportion to what it fixes ("Why") and to what the range score gains; a range gain of nothing or almost, at the price of one more rule, means "cancel" (or "remove" for the fix in question); a rule removed is better than a rule added. **No overfitting**: a rule or a constant that only holds by fitting the analysis's range (values cut for its bounds, the exact shape of its events) is a defect, even without a regression elsewhere.
|
||||
4. **The forbidden**: one detector per family (D-119): `visibility.py`, `obstruction.py`, `target_issue.py`, `thermal_displacement.py`, `no_data.py`, `displacement.py`, no more, no less, and `kind` is the family; no rule specific to a station, a sensor or a date (look for names or instants in the diff); contract `detect(measurements)` (plus `temperature`, `camera`, `metrics` or `end` if the detector declares them, D-124, D-134) and episode keys (`start`, `end`, `kind`, `label`, `text`, `ignore`, `sensors`) unchanged; standard library; threshold registry up to date (`grep -nE "^[A-Z_0-9]+ = " detectors/scripts/*.py`, against the registry).
|
||||
3. **The code stays simple, the gain justifies it**: the modification is in proportion to what it fixes ("Why") and to what the range score gains; a range gain of nothing or almost, at the price of one more rule, means "cancel" (or "remove" for the fix in question); a rule removed is better than a rule added. **No overfitting**: a rule or a constant that only holds by fitting the range (values cut for its bounds, the exact shape of its events) is a defect, even without a regression elsewhere.
|
||||
4. **The forbidden**: one detector per family (`visibility.py`, `obstruction.py`, `target_issue.py`, `thermal_displacement.py`, `no_data.py`, `displacement.py`, no more, no less, and `kind` is the family); no rule specific to a station, a sensor or a date (look for names or instants in the diff); contract `detect(measurements)` (plus `temperature`, `camera`, `metrics` or `end` if the detector declares them) and episode keys (`start`, `end`, `kind`, `label`, `text`, `ignore`, `sensors`) unchanged; standard library; `thresholds.md` up to date (`grep -nE "^[A-Z_0-9]+ = " <DETECTORS>/scripts/*.py`, against the registry).
|
||||
|
||||
You change no file outside your output. Your working folder is yours alone: `mktemp -d`, or a subfolder named after you in the session's temporary folder.
|
||||
You change no file but your output. Your working folder is yours alone: `mktemp -d`.
|
||||
|
||||
## Your decision
|
||||
|
||||
A single pass: no sending back to the upgrader. The upgrader must be able to progress: do not cancel for perfection. **Keep** if nothing goes back, the code stays simple and the range gain justifies it; **remove** when the defect (a regression, a disproportionate complexity, an overfitting, a forbidden) is due to some fixes only, and the others are good without them: the orchestrator reverts their commits; the benchmarks after each fix say it: the fix after which a station goes back is in question; **cancel** otherwise, or for a skipped detector.
|
||||
A single pass: no sending back to the upgrader. The upgrader must be able to progress: do not cancel for perfection. **Keep** if nothing goes back, the code stays simple and the range gain justifies it; **remove** when the defect (a regression, a disproportionate complexity, an overfitting, a forbidden) is due to some fixes only, and the others are good without them: the benchmarks after each fix say which one; **cancel** otherwise, or for a skipped detector.
|
||||
|
||||
## Your output, `validation.md`
|
||||
|
||||
```markdown
|
||||
# <analysis>: validation
|
||||
# Validation
|
||||
|
||||
**Verdict**: keep | remove | cancel
|
||||
**Remove**: S<n>, S<m> (only with the verdict remove)
|
||||
|
||||
Reference in new issue
Block a user